feat: add ReceiverSenderProxy. #168
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fengsp
reviewed
Jul 28, 2023
| global _SENDER_RECEIVER_PROXY_ACTOR | ||
| global _RECEIVER_PROXY_ACTOR_NAME | ||
| _SENDER_RECEIVER_PROXY_ACTOR = SenderReceiverProxyActor.options( | ||
| name=_RECEIVER_PROXY_ACTOR_NAME, **actor_options |
There was a problem hiding this comment.
If this is named with receiver, how send get the SendProxyActor?
There was a problem hiding this comment.
When SenderReceiverProxy is enabled, actor names of sender and receiver are same.
Since some communication backends are bidirectional, meaning that the proxy can do sending/receiving, e.g. SecretFlow Link, grpc streaming. Now we need to apply SecretFlow link to RayFed. That's why we need this PR, though it's not graceful .
Yea, the default is separated actors still. RayFed does not provide ReceiverSendProxy implementation. |
NKcqx
reviewed
Jul 31, 2023
|
Some ut is flaky, i will open a new PR to fix #153 (comment) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
addressesparam in fed.init