Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename functions, variables and classes. #157

Merged
merged 2 commits into from
Jul 19, 2023
Merged

Rename functions, variables and classes. #157

merged 2 commits into from
Jul 19, 2023

Conversation

jovany-wang
Copy link
Collaborator

This is the following up #140 , to address the naming issues.
And it's also the part of #44

@jovany-wang jovany-wang added the p0 label Jul 19, 2023
@jovany-wang jovany-wang added this to the release0.1.1 milestone Jul 19, 2023
@jovany-wang jovany-wang requested review from fengsp, zhouaihui and NKcqx and removed request for fengsp July 19, 2023 03:53
Signed-off-by: Qing Wang <[email protected]>
Copy link
Collaborator

@NKcqx NKcqx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice~ LGTM

Copy link
Collaborator

@fengsp fengsp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@jovany-wang jovany-wang merged commit 44a0556 into main Jul 19, 2023
@jovany-wang jovany-wang deleted the naming branch July 19, 2023 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants