implement runner-initiated split path #54
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
iasoon
force-pushed
the
runner-initiated-splits
branch
2 times, most recently
from
e3d2d32 to
6790427
Compare
iasoon
force-pushed
the
runner-initiated-splits
branch
from
6790427 to
f12fd6b
Compare
| @@ -57,6 +59,7 @@ def ray_execute_bundle( | |||
| transform_buffer_coder: Mapping[str, typing.Tuple[bytes, str]], | |||
| expected_outputs: translations.DataOutput, | |||
| stage_timers: Mapping[translations.TimerFamilyId, bytes], | |||
| split_manager, | |||
There was a problem hiding this comment.
I didn't see we update the call to ray_execute_bundle() with this new split_manager in this patch? Did i miss anything?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
closes #22