skip suspending worker groups if the RayJobDeletionPolicy feature flag is not enabled #2770
+50
−7
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…s is not currently a user-facing API Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
fg-workergroup-suspend
branch
2 times, most recently
from
1cc733d to
2409729
Compare
…tionPolicy feature flag is not enabled Signed-off-by: Rueian <[email protected]>
rueian
force-pushed
the
fg-workergroup-suspend
branch
from
2409729 to
d0cbf34
Compare
…tionPolicy feature flag is not enabled Signed-off-by: Rueian <[email protected]>
|
Hi @kevin85421 and @andrewsykim, this is ready and please take a look. |
kevin85421
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This is a follow-up RP for #2748.
We limit that the
suspendfield on a worker group is only available under the RayJobDeletionPolicy feature gate:Related issue number
Checks