[GCS FT] Add e2e tests for configuring GCS FT with annotations #2766
+109
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: kaihsun <[email protected]>
Signed-off-by: kaihsun <[email protected]>
|
cc @rueian |
Comment on lines
176
to
188
| podTemplateAC := podTemplateSpecApplyConfiguration(headPodTemplateApplyConfiguration(), | ||
| injectRayContainerEnv( | ||
| func() []corev1ac.EnvVarApplyConfiguration { | ||
| envs := []corev1ac.EnvVarApplyConfiguration{ | ||
| *corev1ac.EnvVar().WithName("RAY_REDIS_ADDRESS").WithValue("redis:6379"), | ||
| } | ||
| if tc.redisPasswordEnv != "" { | ||
| envs = append(envs, *corev1ac.EnvVar().WithName("REDIS_PASSWORD").WithValue(tc.redisPasswordEnv)) | ||
| } | ||
| return envs | ||
| }(), | ||
| ), | ||
| ) |
There was a problem hiding this comment.
Why not simply headPodTemplateApplyConfiguration().Spec.Containers[0].WithEnv(...)?
There was a problem hiding this comment.
I at first think this may make code simpler, but it seems not. I removed the helper function to inject env and rayStartParams.
Signed-off-by: kaihsun <[email protected]>
Signed-off-by: kaihsun <[email protected]>
rueian
approved these changes
Jan 17, 2025
MortalHappiness
approved these changes
Jan 18, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Old GCS FT API uses annotations to configure GCS FT behavior. This PR adds e2e tests for it.
Related issue number
Checks