Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Refactor] Remove ingress in service controller #2708

Merged

Conversation

owenowenisme
Copy link
Contributor

Why are these changes needed?

Refer to issue #2707

Related issue number

"Closes #2707"

Checks

k get pods
NAME                                                          READY   STATUS    RESTARTS   AGE
kuberay-operator-696bc84cc4-vtrqs                             1/1     Running   0          3m14s
rayservice-sample-raycluster-bcb7b-head-5ppzt                 1/1     Running   0          2m51s
rayservice-sample-raycluster-bcb7b-small-group-worker-mzvck   1/1     Running   0          2m51s
image Only RayCluster controllers logs are left.
  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

… ingress in service controller

Signed-off-by: owenowenisme <[email protected]>
Copy link
Member

@kevin85421 kevin85421 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@kevin85421 kevin85421 merged commit eb6605d into ray-project:master Jan 2, 2025
24 checks passed
@owenowenisme owenowenisme deleted the rm-svc-cluster-watch-ingress branch January 2, 2025 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[RayService][refactor] RayService cluster watches Ingress
2 participants