Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[kubectl-plugin] fix worker resources in 'kubectl ray create cluster' command #2671

Merged
merged 1 commit into from
Dec 20, 2024
Merged

[kubectl-plugin] fix worker resources in 'kubectl ray create cluster' command #2671

merged 1 commit into from
Dec 20, 2024

Conversation

andrewsykim
Copy link
Collaborator

Why are these changes needed?

Fix a bug where worker group resources are not passed in correctly

Related issue number

#2608

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@chiayi
Copy link
Contributor

chiayi commented Dec 20, 2024 •
edited
Loading

Thank You for catching this. LGTM!

@andrewsykim andrewsykim enabled auto-merge (squash) December 20, 2024 00:36
MortalHappiness
MortalHappiness approved these changes Dec 20, 2024
View reviewed changes
Copy link
Member

@MortalHappiness MortalHappiness left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@andrewsykim andrewsykim merged commit 2c47bbc into ray-project:master Dec 20, 2024
23 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MortalHappiness MortalHappiness MortalHappiness approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@andrewsykim @chiayi @MortalHappiness