[kubectl-plugin] Add e2e test for kubectl ray job submit #2614
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
chiayi
force-pushed
the
kubectl-plugin-e2e
branch
8 times, most recently
from
192dd4d to
732be43
Compare
14 tasks
MortalHappiness
requested changes
Dec 6, 2024
ray-operator/config/samples/kubectl-ray-submit-job/runtime-env-sample.yaml
Outdated
Show resolved
Hide resolved
chiayi
force-pushed
the
kubectl-plugin-e2e
branch
from
732be43 to
b57100a
Compare
MortalHappiness
requested changes
Dec 6, 2024
kubectl-plugin/test/e2e/testdata/rayjob-submit-working-dir/runtime-env-sample.yaml
Outdated
Show resolved
Hide resolved
Comment on lines
7
to
25
| @ray.remote | ||
| class Counter: | ||
| def __init__(self): | ||
| # Used to verify runtimeEnv | ||
| self.name = os.getenv("counter_name") | ||
| assert self.name == "test_counter" | ||
| self.counter = 0 | ||
|
|
||
| def inc(self): | ||
| self.counter += 1 | ||
|
|
||
| def get_counter(self): | ||
| return "{} got {}".format(self.name, self.counter) | ||
|
|
||
| counter = Counter.remote() | ||
|
|
||
| for _ in range(5): | ||
| ray.get(counter.inc.remote()) | ||
| print(ray.get(counter.get_counter.remote())) |
There was a problem hiding this comment.
I think use task would be simpler than actor. We don't need counter. A simple task that checks environment variables and try to import package in it is enough. Something like
import ray
ray.init()
@ray.remote
def f():
# import package
# check package version
# check env vars
ray.get(f.remote())There was a problem hiding this comment.
PTAL, I used 2 packages that aren't dependencies and 2 env vars.
andrewsykim
reviewed
Dec 6, 2024
kubectl-plugin/test/e2e/testdata/ray-job.interactive-mode-no-runtime-env.yaml
Outdated
Show resolved
Hide resolved
chiayi
force-pushed
the
kubectl-plugin-e2e
branch
4 times, most recently
from
2405cbc to
7b11a7c
Compare
chiayi
force-pushed
the
kubectl-plugin-e2e
branch
from
7b11a7c to
a8ae574
Compare
andrewsykim
reviewed
Dec 9, 2024
| spec: | ||
| # The current value is "InteractiveMode", meaning that it will wait for user to submit job and provide the job submission ID | ||
| submissionMode: 'InteractiveMode' | ||
| runtimeEnvYAML: | |
There was a problem hiding this comment.
@kevin85421 @MortalHappiness what's the expected behavior with runtime env when using InteractiveMode. It should be ignored right?
andrewsykim
approved these changes
Dec 9, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
This PR adds test for the
ray job submitcommand.Related issue number
Part of #2608
Checks