Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add e2e autoscaler test for nested remote functions with IdleTimeOut #2610

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

mimiliaogo
Copy link

@mimiliaogo mimiliaogo commented Dec 5, 2024

Why are these changes needed?

Add an end-to-end test for ray-project/ray#48519.

Specifically, add a nested remote function test:

  1. Make sure the autoscaler won't kill a node with blocking workers (i.e, total_resources == available_resources but idle duration = 0). This can happen when the parent node is in a blocking state waiting for its child task on another node to finish.
  2. Autoscaler can downscale node when idle duration > idleTimeOut

Note: Since we're not using the latest Ray image here, this test will fail as expected.
ray-project/ray#48519 should fix this.

Related issue number

Closes #2568

Checks

  • I've made sure the tests are passing.
  • Testing Strategy
    • Unit tests
    • Manual tests
    • This PR is not tested :(

@andrewsykim
Copy link
Collaborator

cc @ryanaoleary

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature] Add E2E Test for Autoscaler Nested Remote Functions
3 participants