[Test][Autoscaler][2/n] Add Ray Autoscaler e2e tests for GPU workers #2181
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rueian
commented
Jun 6, 2024
| parser = argparse.ArgumentParser() | ||
| parser.add_argument('name') | ||
| parser.add_argument('--num-cpus', type=float, default=1) | ||
| parser.add_argument('--num-gpus', type=float, default=0) |
There was a problem hiding this comment.
The argparse allows us to pass --num-gpus later in tests.
rueian
commented
Jun 6, 2024
| @@ -73,5 +80,18 @@ func TestRayClusterAutoscaler(t *testing.T) { | |||
| ExecPodCmd(test, headPod, common.RayHeadContainer, []string{"python", "/home/ray/test_scripts/terminate_detached_actor.py", "actor2"}) | |||
| test.Eventually(RayCluster(test, rayCluster.Namespace, rayCluster.Name), TestTimeoutMedium). | |||
| Should(WithTransform(RayClusterDesiredWorkerReplicas, Equal(int32(0)))) | |||
|
|
|||
| // Create a detached gpu actor, and a worker in the "gpu-group" should be created. | |||
| ExecPodCmd(test, headPod, common.RayHeadContainer, []string{"python", "/home/ray/test_scripts/create_detached_actor.py", "gpu_actor", "--num-gpus=1"}) | |||
There was a problem hiding this comment.
We pass --num-gpus=1 to the script to change the actor resource requirements.
Signed-off-by: Rueian <[email protected]>
Signed-off-by: Rueian <[email protected]>
kevin85421
approved these changes
Jun 9, 2024
15 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why are these changes needed?
Continue the work on #2173 for GPU e2e tests.
Related issue number
#2173 for more details.
Checks