add unit tests

Signed-off-by: Andrew Sy Kim <[email protected]>
ray-project · Dec 16, 2024 · 30adbd6 · 30adbd6
1 parent 0b9ef83
commit 30adbd6
Show file tree

Hide file tree

Showing 3 changed files with 388 additions and 2 deletions.
diff --git a/ray-operator/apis/ray/v1/rayjob_types.go b/ray-operator/apis/ray/v1/rayjob_types.go
@@ -67,7 +67,7 @@ type DeletionPolicy string
 const (
 	DeleteClusterDeletionPolicy DeletionPolicy = "DeleteCluster"
 	DeleteWorkersDeletionPolicy DeletionPolicy = "DeleteWorkers"
-	DeleteSelfDeltionPolicy     DeletionPolicy = "DeleteSelf"
+	DeleteSelfDeletionPolicy    DeletionPolicy = "DeleteSelf"
 	DeleteNoneDeletionPolicy    DeletionPolicy = "None"
 )
 

diff --git a/ray-operator/controllers/ray/rayjob_controller.go b/ray-operator/controllers/ray/rayjob_controller.go
@@ -377,7 +377,7 @@ func (r *RayJobReconciler) Reconcile(ctx context.Context, request ctrl.Request)
 			case rayv1.DeleteWorkersDeletionPolicy:
 				logger.Info("Scaling all worker replicas to 0", "RayCluster", rayJobInstance.Status.RayClusterName)
 				_, err = r.scaleWorkerReplicasToZero(ctx, rayJobInstance)
-			case rayv1.DeleteSelfDeltionPolicy:
+			case rayv1.DeleteSelfDeletionPolicy:
 				logger.Info("Deleting RayJob")
 				err = r.Client.Delete(ctx, rayJobInstance)
 			default: