Add tests and str constructor to GlobPath #437
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…m new dataset methods.
…er schema via two mechanisms, intersect and union.
|
Abandoning to fix lint and merge in more changes for new dataset.from_parquet() method. |
|
Closing |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Small commit to add tests and improve constructor for GlobPath/GlobPathFieldGroup in preparation for using it in Dataset.
Rationale
See Summary.
Changes
See Summary.
Impact
Adds new str constructor so that we don't have to create GlobPaths from client (which should be an internal class).
Testing
make test; make lint
Regression Risk
N/A
Checklist
Additional Notes
N/A