bundle.bbclass: extend do_bundle[file-checksums] #353
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ejoerns
requested changes
Nov 15, 2024
There was a problem hiding this comment.
This looks really useful. Actually, both files are not part of SRC_URI and thus their checksum would not be recorded by default.
However, since (despite the name does not suggest it) both could also be PKCS#11 URIs, I guess using False for the boolean part is required here.
Rerun the do_bundle task when the contents of RAUC_CERT_FILE or RAUC_KEY_FILE have changed. Since both can also be PKCS#11 URIs, set the boolean flag to False. Signed-off-by: Grygorii Tertychnyi <[email protected]>
grembeter
force-pushed
the
wip/file-checksums/master
branch
from
ef3ecb4
to
a096a16
Compare
|
Unfortunately, I cannot test it with PKCS#11 URIs. |
@grembeter That shouldn't matter. The point is that the URIs are not valid paths in the file system and thus cannot be tracked. And using Thanks for updating the PR! |
ejoerns
approved these changes
Nov 16, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rerun
do_bundletask whenRAUC_CERT_FILEorRAUC_KEY_FILEfiles have been changed on the disk.