-
Notifications
You must be signed in to change notification settings - Fork 935
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add SparkFun ThingPlus RP2350 #2038
base: develop
Are you sure you want to change the base?
Add SparkFun ThingPlus RP2350 #2038
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks good. Thanks for adding the default cyw43 pins.
LGTM, but I guess this might need a
line to satisfy the upcoming #2034 ? ping @will-v-pi |
Yeah, that’d be good, so I don’t have to rebase #2034 on top of this to add it |
Done! |
|
||
// gpio pin for spi data out to the cyw43 chip | ||
#ifndef CYW43_DEFAULT_PIN_WL_DATA_OUT | ||
#define CYW43_DEFAULT_PIN_WL_DATA_OUT 24u |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm just looking at this as part of the update for CYW43 support in arduino-pico on the RP2350 boards, so maybe I'm missing something, but are data_in, data_out, and host_wake all on pin 24?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yep! Theoretically any GPIO pins can be used (see here: #1938 (comment)), but Raspberry Pi managed to cleverly connect all 3 pins of the radio to a single GPIO pin on the host processor. For reference, see the Pico W datasheet (schematic on page 23). This board uses the same connections with the same resistors to avoid contention.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
https://github.com/raspberrypi/pico-sdk/blob/develop/src/rp2_common/pico_cyw43_driver/cyw43_bus_pio_spi.c is where the software-side magic works.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Nice, thanks for the explanation!
Upcoming board from us!