Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

More CYW43 config tweaks #2033

Open
wants to merge 1 commit into
base: develop
Choose a base branch
from
Open

More CYW43 config tweaks #2033

wants to merge 1 commit into from

Conversation

lurch
Copy link
Contributor

@lurch lurch commented Nov 11, 2024

This is a follow-up to the previous #2002 (I spotted the typo, and ended up "fixing" a few other things in the process of fixing that!).

@kilograham kilograham added this to the 2.1.0 milestone Nov 11, 2024
@kilograham
Copy link
Contributor

I suspect this may conflict with the int_frac change which i'd like to merge first

@lurch
Copy link
Contributor Author

lurch commented Nov 11, 2024

I suspect this may conflict with the int_frac change which i'd like to merge first

Undoubtedly. Your PR is much chunkier than this one, so I'm happy to rebase this after #1926 has been merged 👍

 - Re-synchronise the PICO_CMAKE_CONFIG: entries with the corresponding PICO_CONFIG: entries
 - Fix a silly typo I made in #2002
 - Enhance config-extraction scripts to catch similar typos in future
@lurch
Copy link
Contributor Author

lurch commented Nov 12, 2024

This has now been rebased on the latest develop, now that #1926 has been merged. Surprisingly, there were no conflicts! 🥳

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants