Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove Segger RTT from pico-btstack #1995

Open
wants to merge 2 commits into
base: develop
Choose a base branch
from

Conversation

peterharperuk
Copy link
Contributor

We now have this in the SDK so adding it again in pico-btstack leads to link errors.

@lurch
Copy link
Contributor

lurch commented Oct 23, 2024

Ahhh, looks like this PR is a consequence of #1411

@lurch
Copy link
Contributor

lurch commented Oct 23, 2024

I don't know much about cmake / compilers / linkers / etc. but does this change potentially mean that a project using pico_btstack might fail to build if pico_stdio_rtt isn't also included / enabled? 🤷‍♂️

@peterharperuk
Copy link
Contributor Author

peterharperuk commented Oct 23, 2024

pico_btstack might fail to build if pico_stdio_rtt isn't also included / enabled?

Good point. Let me check.

later: groan - you get a linker error :(

We now have this in the SDK so adding it again in pico-btstack leads to
link errors.

But it's possible to use the btstack RTT functionality by defining
ENABLE_SEGGER_RTT=1, and if we're not using pico_stio_rtt we still need
to add the btstack RTT source.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants