Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Performance improvment #2 #7

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Performance improvment #2 #7

wants to merge 6 commits into from

Conversation

200MPH
Copy link
Contributor

@200MPH 200MPH commented Jan 28, 2020

No description provided.

@coveralls
Copy link

coveralls commented Jan 28, 2020 •
edited
Loading

Pull Request Test Coverage Report for Build 47

  • 10 of 12 (83.33%) changed or added relevant lines in 2 files are covered.
  • 7 unchanged lines in 2 files lost coverage.
  • Overall coverage decreased (-14.5%) to 80.328%
Changes Missing Coverage Covered Lines Changed/Added Lines %
src/Factories/UkBankHolidayFactory.php 8 10 80.0%
Files with Coverage Reduction New Missed Lines %
src/Objects/DataRetrievers/GovUkDataRetriever.php 1 75.86%
src/Objects/CacheDrivers/LaravelCacheDriver.php 6 0%
Totals Coverage Status
Change from base Build 44: -14.5%
Covered Lines: 49
Relevant Lines: 61
💛 - Coveralls

@200MPH
Copy link
Contributor Author

200MPH commented Jan 28, 2020

Hello,
Coverage still returns a fail.
I do not know how to fix it.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@200MPH @coveralls