-
Notifications
You must be signed in to change notification settings - Fork 12
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Adding a dependencies.yaml
file
#9
Adding a dependencies.yaml
file
#9
Conversation
Is this PR meant to target |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM as far as I can tell. Didn't #8 have more changes?
Also, I think the title could be updated.
Finally, I hope you learned not to rewrite history and force-push to a remote repo unless you need to e.g. remove secrets or proprietary info ;)
AFAIK #8 also just adds a dependencies file. I think
Done.
😅 |
Currently waiting on https://github.com/rapidsai/ops/issues/3563 in order to rename branch |
These changes have been made to the upstream repo. Addressing feedback and requesting one more review to get this finally merged! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I pushed a commit with changes from pre-commit run --all-files
and this now looks good to me.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
without knowing much about nx-cugraph
's dependencies, this PR looks good to me.
Replaces #8. Accidentally closed the PR trying to revert some changes.