[CI] Adding CI Workflows: checks, changed-files, builds #6
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Branch 24.12 setup repo
nv-rliu
added
breaking
Merged
nv-rliu
changed the title
build_python.sh
nv-rliu
changed the title
build_python.shchecks and build_python.sh
Merge Branch with `dependencies.yaml`
Co-authored-by: Bradley Dice <[email protected]>
This reverts commit 81861a0.
|
@KyleFromNVIDIA requesting another review! |
jameslamb
requested changes
Oct 31, 2024
There was a problem hiding this comment.
@KyleFromNVIDIA I've joined here as well because @nv-rliu asked me to (he and I have been pairing on this repo). Feel free to dismiss your review and take yourself off the reviewers list if you'd like to focus on other things.
@nv-rliu I left some comments for your consideration.
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
…/nx-cugraph into branch-24.12-pr-workflow
jameslamb
requested changes
Oct 31, 2024
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
Co-authored-by: James Lamb <[email protected]>
jameslamb
approved these changes
Nov 1, 2024
There was a problem hiding this comment.
Just two more small suggestions... I'll apply them inline to kick off another build.
@KyleFromNVIDIA can you please re-review or dismiss your review?
|
Thanks for removing your name from reviewers @KyleFromNVIDIA , but your old review was still blocking: 
I just dismissed it. |
|
/merge |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes https://github.com/rapidsai/graph_dl/issues/636
Closes https://github.com/rapidsai/graph_dl/issues/637
This PR adds the following jobs in CI:
changed-filesconda-python-buildwheel-build-nx-cugraph