Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add experimental version of leiden_communities #50

Open
wants to merge 3 commits into
base: branch-25.02
Choose a base branch
from

Conversation

eriknw
Copy link
Contributor

@eriknw eriknw commented Nov 22, 2024

This function is not yet defined or implemented in NetworkX, and there is high probability the API may change once added to NetworkX. For now, this is "best effort" and simply mimics PLC leiden.

This function is not yet defined or implemented in NetworkX, and
there is high probability the API may change once added to NetworkX.
@eriknw eriknw added improvement Improves an existing functionality non-breaking Introduces a non-breaking change labels Nov 22, 2024
@eriknw
Copy link
Contributor Author

eriknw commented Nov 27, 2024

It appears that theta parameter is not used, so I removed it for now.

First, it is ignored in the C->Python API here:
https://github.com/rapidsai/cugraph/blob/1f1cace91e9b97c11dc6d57026360c3a0a919676/cpp/src/c_api/leiden.cpp#L128-L141

Second, it is ignored in the refinement step here (done in rapidsai/cugraph#3990):
https://github.com/rapidsai/cugraph/blob/1f1cace91e9b97c11dc6d57026360c3a0a919676/cpp/src/community/detail/refine_impl.cuh#L107-L124

@eriknw
Copy link
Contributor Author

eriknw commented Nov 27, 2024

Begin adding to networkx here: networkx/networkx#7743

Copy link
Contributor

@rlratzel rlratzel left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As @eriknw mentioned in the description, this is still experimental and is not exposed to users by default (because it is not currently available in NetworkX) and is low risk, and also may be useful to have in 24.12. I'm fine merging this into 24.12 for those reasons.

@rlratzel rlratzel changed the base branch from branch-24.12 to branch-25.02 December 5, 2024 19:35
@rlratzel
Copy link
Contributor

rlratzel commented Dec 5, 2024

re: 24.12 vs. 25.02 - on second thought, @eriknw pointed out the potential for the API to change which would make 24.12 incompatible with future NX versions.

@rlratzel rlratzel added this to the 25.02 milestone Dec 5, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
improvement Improves an existing functionality non-breaking Introduces a non-breaking change
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants