Clip logstd

rapidsai · Oct 4, 2023 · 86ac069 · 86ac069
1 parent 444effc
commit 86ac069
Show file tree

Hide file tree

Showing 2 changed files with 2 additions and 2 deletions.
diff --git a/legateboost/objectives.py b/legateboost/objectives.py
@@ -167,7 +167,7 @@ def transform(self, pred: cn.ndarray) -> cn.ndarray:
         # reshape this nicely for the user so mean and variance have their own dimension
         pred = pred.reshape((pred.shape[0], pred.shape[1] // 2, 2))
         # don't let the variance go to zero
-        pred[:, :, 1] = cn.maximum(pred[:, :, 1], -5)
+        pred[:, :, 1] = cn.clip(pred[:, :, 1], -5, 5)
         return pred
 
 

diff --git a/legateboost/test/test_objective.py b/legateboost/test/test_objective.py
@@ -8,7 +8,7 @@ def test_normal():
     obj = lb.NormalObjective()
     y = cn.array([[1.0], [2.0], [3.0]])
     init = obj.initialise_prediction(y, cn.array([1.0, 1.0, 1.0]), True)
-    assert cn.allclose(init, cn.array([y.mean(), y.var()]))
+    assert cn.allclose(init, cn.array([y.mean(), cn.log(y.std())]))
 
 
 def test_log_loss():