Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update sccache to 0.7.4 so that we get nvc++ support #177

Merged
merged 4 commits into from
Dec 12, 2023
Merged

Update sccache to 0.7.4 so that we get nvc++ support #177

merged 4 commits into from
Dec 12, 2023

Conversation

miscco
Copy link
Collaborator

@miscco miscco commented Nov 16, 2023

No description provided.

trxcllnt
trxcllnt requested changes Nov 16, 2023
View reviewed changes
Copy link
Collaborator

@trxcllnt trxcllnt left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Also bump the version in sccache/devcontainer-feature.json

@bdice
Copy link
Contributor

bdice commented Dec 9, 2023 •
edited
Loading

FYI: we're updating RAPIDS CI images to sccache 0.7.4 here: rapidsai/ci-imgs#97

Maybe we can align on that version and merge this to 24.02 instead of 23.12?

@copy-pr-bot copy-pr-bot
Copy link

copy-pr-bot bot commented Dec 10, 2023

This pull request requires additional validation before any workflows can run on NVIDIA's runners.

Pull request vetters can view their responsibilities here.

Contributors can view more details about this message here.

@trxcllnt trxcllnt changed the title Update sccache to 0.7.2 so that we get nvc++ support Update sccache to 0.7.4 so that we get nvc++ support Dec 10, 2023
@trxcllnt trxcllnt merged commit aba251d into rapidsai:branch-23.12 Dec 12, 2023
160 checks passed
@bdice
Copy link
Contributor

bdice commented Dec 12, 2023

@trxcllnt This was merged to 23.12. Do we have forward mergers set up for branch-24.02? Can we work with ops to get those set up?

@trxcllnt trxcllnt mentioned this pull request Feb 9, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@trxcllnt trxcllnt trxcllnt approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@miscco @bdice @trxcllnt