Add CUDA 11.8 devcontainer to CCCL matrix #173
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
miscco
reviewed
Nov 10, 2023
| @@ -77,6 +77,7 @@ include: | |||
| images: | |||
| - {features: [*nvhpc_prev, *python, *cccl_dev], env: *nvhpc_env} | |||
| - {features: [*nvhpc_curr, *python, *cccl_dev], env: *nvhpc_env} | |||
| - {features: [*gcc_11, {<<: *cuda_prev_max, <<: *cccl_cuda_opts}, *python, *cccl_dev], env: *gcc_env} | |||
There was a problem hiding this comment.
You put them into the CCCL bracket. Would it make sense to add a separate block with cuCollections as a target.
With that container in here, we are running risk that we might change the devcontainer when we do changes to the CCCL ones
There was a problem hiding this comment.
For cuCollections we try to adhere to the CCCL setup as close as possible. Although, we only test a small subset of the CCCL matrix. I'm fine with leaving this in the CCCL section, since all of the other images in our matrix are CCCL images anyway.
miscco
approved these changes
Nov 10, 2023
|
I started a deployment so that the image gets pushed to the registry https://github.com/rapidsai/devcontainers/actions/runs/6827022148 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds a single image to the CCCL devcontainer matrix which is needed to run cuCollections CI tests.
CC @jrhemstad @bdice