-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[BUG] Fix CAGRA graph optimization bug #565
base: branch-25.02
Are you sure you want to change the base?
[BUG] Fix CAGRA graph optimization bug #565
Conversation
It seems too severe to abort the optimization process if there is even one invalid node, so I updated the code not to abort unless the pruned graph can be generated even if there are invalid nodes in the initial kNN graph. |
@anaruse Can you review the update? It is related to merging the pruned graph and MST optimization edges. |
The merging process of the pruned and revedge graphs is inappropriate, resulting in neighbor index duplication. This PR fixes the issue and adds the validation of graph indices at the end of the
graph::optimze
function.The simplest solution to fix this issue is 1151511, but it ignores the memory space optimization by rapidsai/raft@12480cf. The code changes in this PR apply the memory space optimization to the simplest solution to remove the memory space for the pruned graph (
pruned_graph
).This PR also fixes a problem that throwing an exception from an OMP loop does not work as expected.