Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Weekly Updater Action #19779

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

h00die
Copy link
Contributor

@h00die h00die commented Dec 30, 2024

Fixes #18120

This PR gets us inline for having weekly updates to data files and external files. We do this with the following changes:

  1. Update UA string updater python script to ruby
  2. Update joomla component gatherer python script to ruby
  3. Sync all the ruby update scripts with -h , descriptions, outputs, etc
  4. build a github action which runs weekly, runs the update scripts, and submits a PR with the changes

Why is this important?

Here's an example PR that gets submitted: h00die#32

@h00die h00die changed the title weekly updater action Weekly Updater Action Dec 30, 2024
@h00die
Copy link
Contributor Author

h00die commented Jan 1, 2025

Whoever is assigned this, I would suggest landing #19755 and #19774 first, or closing those out as this will supersede them in a week.

@adfoster-r7
Copy link
Contributor

Merged in those two pre-requisite PRs now, thanks!

Looks like there's a small merge conflict for this PR to resolve 🤞

Conflicting files
tools/dev/update_user_agent_strings.py

@h00die
Copy link
Contributor Author

h00die commented Jan 1, 2025

I wanted to keep attribution (and history) on the .py files, so the workflow was git mv <name>.py <name>.rb, then overwrite the content with a ruby version.

My dev box is down for the day, so if you want to resolve that it should be trivial with that workflow. If not, I can take care of it in like 25hrs or so

@h00die h00die force-pushed the action_update_weekly branch from 0b5ff81 to 967c9b3 Compare January 2, 2025 03:35
@jmartin-tech
Copy link
Contributor

Not sure if the restriction has change, github actions were previously restricted from opening PRs in the R7 org.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Automate Updates for Data Frequently Updated
3 participants