Update error message for meterpreter file contents test #18661
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adfoster-r7
commented
Jan 4, 2024
| @@ -158,7 +158,7 @@ def test_file | |||
| final_contents = read_file(datastore['BaseFileName']) | |||
| ret &&= final_contents == 'foobarbaz' | |||
| unless ret | |||
| vprint_status("Didn't read what we wrote, actual file on target: |#{file_contents.inspect}| - #{file_contents.bytes.inspect}") | |||
| vprint_status("Didn't read what we wrote, actual file on target: |#{final_contents.inspect}| - #{final_contents.bytes.inspect}") | |||
There was a problem hiding this comment.
Original issue from CI in the error scenario:
[read] [-] [should append text files] FAILED: should append text files
[read] [-] [should append text files] Exception: NameError: undefined local variable or method `file_contents' for #<Module:post/test/file datastore=[...etc...etc..
Did you mean? final_contents
dwelch-r7
approved these changes
Jan 4, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Update error message for meterpreter file contents test
Verification
Statically verify that the code change makes sense