Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Put custom dns resolver behind feature flag #18660

Merged

Conversation

dwelch-r7
Copy link
Contributor

@dwelch-r7 dwelch-r7 commented Jan 4, 2024

Resolves #18639 #18574 #18624

There is an issue with the custom dns resolver which is leading to some issues for users, I believe it was intended to be placed behind a feature flag dns_feature so that's what I'm doing here to resolve the issue and give us time to properly investigate the issue

@dwelch-r7 dwelch-r7 added the rn-fix release notes fix label Jan 4, 2024
@adfoster-r7 adfoster-r7 merged commit 1c53799 into rapid7:master Jan 4, 2024
58 checks passed
@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Jan 4, 2024

Release Notes

Fixes a ipaddr.rb:622:in match: stack level too deep exception that was being raised on msfconsole startup

@adfoster-r7
Copy link
Contributor

cc @sempervictus for visibility - I don't think you're using this functionality yet, but just in case 👍

@adfoster-r7
Copy link
Contributor

adfoster-r7 commented Jan 4, 2024

We'll still need to fix the actual DNS issues with the new @@resolver pattern, but this should've been behind a feature flag from the get-go so this is all good for now 👍

@sempervictus
Copy link
Contributor

All for!
Re DNS issues: apologies if i missed tags on other issues, happy to help tackle whatever stragglers/weirdness remains. Please dont be shy to email/slack me if im unresponsive here (the juggling of running chainsaws never ends, but getting stuff done here for the public is actually good for what passes for a "soul" in leathernecks 😉 ).

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-fix release notes fix
Projects
None yet
Development

Successfully merging this pull request may close these issues.

System Stack Error
3 participants