Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix flakey test failure #18487

Merged
merged 1 commit into from
Oct 25, 2023
Merged

Conversation

adfoster-r7
Copy link
Contributor

Fix a flakey test failure spotted on CI

02:00:28 Msf::ModuleManager ......................F..........................
02:00:28 
02:00:28   1) Msf::ModuleManager it should behave like Msf::ModuleManager::Cache #module_info_by_path_from_database! with database cache cache entry is expected to be within 1 of 2023-09-14 19:22:04.267979467 -0500
02:00:28      Failure/Error: it { expect(subject[:modification_time]).to be_within(1.second).of(pathname_modification_time) }
02:00:28        expected 2023-10-24 19:54:18.000000000 -0500 to be within 1 of 2023-09-14 19:22:04.267979467 -0500
02:00:28      Shared Example Group: "Msf::ModuleManager::Cache" called from ./spec/lib/msf/core/module_manager_spec.rb:29
02:00:28      # ./spec/support/shared/examples/msf/module_manager/cache.rb:413:in `block (5 levels) in <top (required)>'

Verification

Ensure CI passes

@dwelch-r7 dwelch-r7 merged commit 9e77eba into rapid7:master Oct 25, 2023
32 checks passed
@dwelch-r7 dwelch-r7 added the rn-no-release-notes no release notes label Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
rn-no-release-notes no release notes
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants