corrected options confict between module and ldap mixin #18448
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Yet this needs to be fixed: I’ll see tomorrow, likely to test for ldap.bind status |
Few more instances corrected
|
PR is ready for review |
|
Just for info, I believe, the renaming of parameters in ldap mixin was required due to parameter change in Net::LDAP ruby library. |
|
Sorry for the delay, thanks for patching! I don't have a target to verify, but statically the code changes look good to me - and this contributor ran through the module update successfully too 👍 |
Release NotesFixes and updates the |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR corrects an Option conflict between
Msf::Exploit::Remote::LDAPandauxiliary/admin/ldap/vmware_vcenter_vmdir_auth_bypassmodule. As reported in #18091It seems around this commit 9a6c298 the
BIND_DBandBIND_PWoptions oflib/msf/core/exploit/remote/ldap.rbstarted to move towards renaming intoUSERNAMEandPASSWORD. Unfortunately same options have been used inauxiliary/admin/ldap/vmware_vcenter_vmdir_auth_bypassmodule for a different purpose.This PR adds a prefix
NEW_to theauxiliary/admin/ldap/vmware_vcenter_vmdir_auth_bypassmodule optionsVerification
I don't have a test system on hand at the moment, I appreciate if someone tests both scenarios:
https://github.com/HynekPetrak/metasploit-framework/blob/fix_vmware_vcenter_vmdir_auth_bypass/documentation/modules/auxiliary/admin/ldap/vmware_vcenter_vmdir_auth_bypass.md#vmware-vcenter-server-67-virtual-appliance-on-esxi-vulnerable-target
https://github.com/HynekPetrak/metasploit-framework/blob/fix_vmware_vcenter_vmdir_auth_bypass/documentation/modules/auxiliary/admin/ldap/vmware_vcenter_vmdir_auth_bypass.md#vmware-vcenter-server-6702-virtual-appliance-on-esxi-not-vulnerable-target