Fix pass by reference bug on the module side for windows error exploit #18406
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This fixes a bug found by @cdelafuente-r7 where we're using a pass-by-reference for strings from the
mkdir
method to the cleanup methods. This means that if we alter the string used to create the directory later in the module, the cleanup method tries to delete whatever is in the string at the end of the module, rather than what was in it when we calledmkdir
. To fix it in this module, I just added a local method calledclone_mkdir
where we clone the string before passing it into mkdir.We're working on a fix that will negate the need for this here: #18403