-
Notifications
You must be signed in to change notification settings - Fork 14.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Kerberos ticket_search fix passing in a workspace #18400
Kerberos ticket_search fix passing in a workspace #18400
Conversation
9f26291
to
c1abf37
Compare
@dwelch-r7 do you want to keep this as a separate PR to framework or move it to a PR for #18373 since that would make it easier to test and land? Plus, then I could verify it, and push merge it into my PR in no time |
Thanks @dwelch-r7 for fixing this. It looks good to me. I'll go ahead and land it. Example output using PR #18373
|
Release NotesThis fixes an issue when searching for a Kerberos ticket and passing in the workspace. The workspace is now correctly used to query the database. |
Thanks to @h00die for spotting this issue over here #18373 (comment)
When getting kerberos tickets the workspace was being passed in but being ignored, we were always using the users current workspace
This PR actually uses the passed in workspace while defaulting to the users current workspace
Before (using
db_stats
provided by #18373)Both workspaces have the same number in the
Kerberos Cache
column as the current workspaceAfter (using
db_stats
provided by #18373)The correct number is displayed for each workspace regardless of the current workspace