Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump rancher/norman #1338

Open
wants to merge 6 commits into
base: master
Choose a base branch
from
Open

Conversation

sboschman
Copy link
Contributor

Issue: #1237

Problem

Update rancher/norman dep to latest release

Solution

Testing

Also includes a golang bump from 1.19 to 1.22, as forced by rancher/norman:

go: github.com/rancher/[email protected] requires go >= 1.22; switching to go1.22.2
go: upgraded go 1.19 => 1.22
go: added toolchain go1.22.2

Signed-off-by: Sverre Boschman <[email protected]>
Signed-off-by: Sverre Boschman <[email protected]>
Signed-off-by: Sverre Boschman <[email protected]>
Signed-off-by: Sverre Boschman <[email protected]>
Signed-off-by: Sverre Boschman <[email protected]>
@sboschman
Copy link
Contributor Author

@ericpromislow, like you mentioned, ci also fails on the lint step

==> Checking that code complies with gofmt requirements...
==> Checking that code complies with golint requirements...
go: modules disabled by GO111MODULE=off; see 'go help modules'
make: *** [GNUmakefile:52: lint] Error 1
time="2024-04-17T19:01:44.158359885Z" level=info msg="shim disconnected" id=10a828e96596b106fdf1c7546e70b0f9fb9d0ab92a881336bebef3830363b2cb
time="2024-04-17T19:01:44.158395642Z" level=info msg="ignoring event" container=10a828e96596b106fdf1c7546e70b0f9fb9d0ab92a881336bebef3830363b2cb module=libcontainerd namespace=moby topic=/tasks/delete type="*events.TaskDelete"
time="2024-04-17T19:01:44.158411550Z" level=warning msg="cleaning up after shim disconnected" id=10a828e96596b106fdf1c7546e70b0f9fb9d0ab92a881336bebef3830363b2cb namespace=moby
time="2024-04-17T19:01:44.158424899Z" level=info msg="cleaning up dead shim"
time="2024-04-17T19:01:44.164308783Z" level=warning msg="cleanup warnings time=\"2024-04-17T19:01:44Z\" level=info msg=\"starting signal loop\" namespace=moby pid=497 runtime=io.containerd.runc.v2\n"
make: *** [GNUmakefile:12: docker-build] Error 2
Exit Code 2

After removing the GO111MODULE from the GNUmakefile , as you mentioned, and running go mod tidy (prolly should have done that right away in the first commit) the result is:

==> Running testing...
go test "./rancher2" || exit 1
# sigs.k8s.io/controller-runtime/pkg/healthz
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/healthz/healthz.go:91:94: undefined: sets.Set
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/healthz/healthz.go:190:46: undefined: sets.Set
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/healthz/healthz.go:193:15: undefined: sets.New
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/healthz/healthz.go:195:14: undefined: sets.New
# sigs.k8s.io/controller-runtime/pkg/cache
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/cache/cache.go:83:71: undefined: toolscache.ResourceEventHandlerRegistration
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/cache/cache.go:89:115: undefined: toolscache.ResourceEventHandlerRegistration
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/cache/cache.go:93:39: undefined: toolscache.ResourceEventHandlerRegistration
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/cache/multi_namespace_cache.go:299:103: undefined: toolscache.ResourceEventHandlerRegistration
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/cache/multi_namespace_cache.go:300:40: undefined: toolscache.ResourceEventHandlerRegistration
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/cache/multi_namespace_cache.go:312:147: undefined: toolscache.ResourceEventHandlerRegistration
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/cache/multi_namespace_cache.go:313:40: undefined: toolscache.ResourceEventHandlerRegistration
/go/pkg/mod/sigs.k8s.io/[email protected]/pkg/cache/multi_namespace_cache.go:325:66: undefined: toolscache.ResourceEventHandlerRegistration
# k8s.io/client-go/applyconfigurations/meta/v1
/go/pkg/mod/github.com/rancher/[email protected]/applyconfigurations/meta/v1/unstructured.go:64:38: cannot use doc (variable of type *"github.com/google/gnostic/openapiv2".Document) as *"github.com/google/gnostic-models/openapiv2".Document value in argument to proto.NewOpenAPIData
FAIL	github.com/rancher/terraform-provider-rancher2/rancher2 [build failed]
FAIL

@ericpromislow
Copy link

Was busy today - I can look at this tomorrow

Signed-off-by: Sverre Boschman <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants