-
Notifications
You must be signed in to change notification settings - Fork 228
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Bump rancher/norman #1338
Open
sboschman
wants to merge
6
commits into
rancher:master
Choose a base branch
from
sboschman:update-norman
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Bump rancher/norman #1338
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Sverre Boschman <[email protected]>
Signed-off-by: Sverre Boschman <[email protected]>
Signed-off-by: Sverre Boschman <[email protected]>
Signed-off-by: Sverre Boschman <[email protected]>
Signed-off-by: Sverre Boschman <[email protected]>
@ericpromislow, like you mentioned, ci also fails on the lint step
After removing the
|
Was busy today - I can look at this tomorrow |
Signed-off-by: Sverre Boschman <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #1237
Problem
Update rancher/norman dep to latest release
Solution
Testing
Also includes a golang bump from 1.19 to 1.22, as forced by rancher/norman: