Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[dev-v2.9] rancher-monitoring: Add compatibility to IPv6 only clusters #3465

Open
wants to merge 3 commits into
base: dev-v2.9
Choose a base branch
from
Open

[dev-v2.9] rancher-monitoring: Add compatibility to IPv6 only clusters #3465

wants to merge 3 commits into from

Conversation

fayak
Copy link

@fayak fayak commented Feb 13, 2024

Problem

Our cluster is IPv6 only. Having nginx listening only on IPv6 breaks the svc. This allows both ipv4 and v6

Solution

listen additionally on ipv6

Testing

Tested on our cluster with success

@github-actions GitHub Actions
Copy link

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:- 
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@fayak fayak mentioned this pull request Feb 13, 2024
Closed
joshmeranda
joshmeranda requested changes Feb 13, 2024
View reviewed changes
Copy link
Contributor

@joshmeranda joshmeranda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @fayak, thanks for your contribution! Before we can approve this, can you go and follow the worfklow outlined here?

Basically this should require the following steps:

  1. export PACKGE=rancher-monitoring/rancher-monitoring
  2. make prepare
  3. apply the changes from this PR to packages/rancher-monitoring/rancher-monitoring
  4. make patch
  5. commit the changes to packages/rancher-monitoring/rancher-monitoring/generated-changes
  6. make clean
  7. make charts
  8. commit changes to charts/rancher-monitoring with message "make charts"

Thanks in advance!

@lucasmlp lucasmlp changed the title rancher-monitoring: Add compatibility to IPv6 only clusters [dev-v2.9] rancher-monitoring: Add compatibility to IPv6 only clusters Mar 1, 2024
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

1 similar comment
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 3, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@fayak fayak requested a review from a team as a code owner May 6, 2024 13:18
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

2 similar comments
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

fayak added 2 commits May 6, 2024 17:07
@fayak
rancher-monitoring: add scrapeconfig CRD, update Prometheus CRD to
a1e507b 
0.73.2, allow operator to read ScrapeConfig CRD

ScrapeConfig: allow operator to read them

prometheuses CRD update to 0.73.2
@fayak
rancher-monitoring: revert broken 4b4ee3f
49946da
@github-actions GitHub Actions
Copy link

github-actions bot commented May 6, 2024

Validation steps

  • Ensure all container images have repository and tag on the same level to ensure that all container images are included in rancher-images.txt which are used by airgap customers.
  Ex:-
    longhorn-controller:
      repository: rancher/hardened-sriov-cni
      tag: v2.6.3-build20230913
  • Add a 👍 (thumbs up) reaction to this comment once done. CI won't pass without this reaction to the github-action bot's latest validation comment.
  • Approve the PR to run the CI check.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joshmeranda joshmeranda joshmeranda requested changes

Requested changes must be addressed to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@fayak @joshmeranda