Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support modal background opacity through CustomJson (RMCCX-7327) #396

Conversation

maureenorea-clores
Copy link
Collaborator

Description

  • Support background opacity setting for modal capaign
  • Improve CustomJson deserializer

Links

RMCCX-7327

Checklist

  • I have read the contributing guidelines.
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I checked that all possible internal and platform/library exceptions are gracefully handled and will not crash the host app
  • I checked for open & known issues (especially crashes) for any newly added platform APIs or libraries
  • I tested non-trivial changes on a real device
  • I added ticket/changes in changelog
  • I ran ./gradlew check without errors

Copy link

sonarcloud bot commented Sep 24, 2024

@rakutentech-danger-bot
Copy link
Collaborator

2 Warnings
⚠️ Branch name "feat/RMCCX-7327_dark-background" should match format: <type>/<ticket-no>_<short-desc> or <type>/<short-desc> or release/<version or desc>.
⚠️ PR title "feat: support modal background opacity through CustomJson (RMCCX-7327)" should append ticket number(s).

JaCoCo Code Coverage 97.35% ✅

Class Covered Meta Status
com/rakuten/tech/mobile/inappmessaging/runtime/view/InAppMessageModalView 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/responses/ping/Message 93% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/customjson/CustomJsonDeserializer 50% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/customjson/CustomJson 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/customjson/MessageMapper 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/ui/UiMessage 94% 0%

Generated by 🚫 Danger

Copy link
Contributor

@mdusmangani-jp mdusmangani-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maureenorea-clores maureenorea-clores merged commit f1fb3b6 into rakutentech:master Sep 24, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants