Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: add console logging (RMCCX-6876) #390

Conversation

maureenorea-clores
Copy link
Collaborator

@maureenorea-clores maureenorea-clores commented Aug 9, 2024

Description

  • Update and add logs

Links

N/A

Checklist

  • I have read the contributing guidelines.
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I checked that all possible internal and platform/library exceptions are gracefully handled and will not crash the host app
  • I checked for open & known issues (especially crashes) for any newly added platform APIs or libraries
  • I tested non-trivial changes on a real device
  • I added ticket/changes in changelog
  • I ran ./gradlew check without errors

Copy link

sonarcloud bot commented Aug 9, 2024

@rakutentech-danger-bot
Copy link
Collaborator

4 Warnings
⚠️ Tests were not updated.
⚠️ Branch name "improve/RMCCX-6876_prod-logs" should match format: <type>/<ticket-no>_<short-desc> or <type>/<short-desc> or release/<version or desc>.
⚠️ PR title "improve: add console logging (RMCCX-6876)" should append ticket number(s).
⚠️ No coverage data found for com/rakuten/tech/mobile/inappmessaging/runtime/manager/DisplayManager

JaCoCo Code Coverage 97.58% ✅

Class Covered Meta Status
com/rakuten/tech/mobile/inappmessaging/runtime/manager/DisplayManager No coverage data found : -% No coverage data found : -% 🃏
com/rakuten/tech/mobile/inappmessaging/runtime/manager/MessageReadinessManager 96% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/view/InAppMessageBaseView 93% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/view/InAppMessagingTooltipView 74% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/coroutine/MessageActionsCoroutine 95% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/workers/DisplayMessageWorker 88% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/workers/ImpressionWorker 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/workers/MessageMixerWorker 95% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/workers/ConfigWorker 92% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/workers/MessageEventReconciliationWorker 50% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/responses/ping/Message 87% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/utils/EventMatchingUtil 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/utils/WorkerUtils 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/utils/Initializer 83% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/utils/MessageEventReconciliationUtil 88% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/utils/InAppLogger 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/repositories/CampaignRepository 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/EventTrackerHelper 87% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/InAppMessaging 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/InApp 96% 0%

Generated by 🚫 Danger

@maureenorea-clores maureenorea-clores changed the base branch from master to release/v7.7.0 August 21, 2024 06:49
Copy link
Contributor

@mdusmangani-jp mdusmangani-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maureenorea-clores maureenorea-clores merged commit e03c931 into rakutentech:release/v7.7.0 Aug 22, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants