Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

improve: update debugging logs #378

Merged

Conversation

maureenorea-clores
Copy link
Collaborator

@maureenorea-clores maureenorea-clores commented Jun 7, 2024

Description

Added informative logs

Links

N/A

Checklist

  • I have read the contributing guidelines.
  • I wrote/updated tests for new/changed code
  • I removed all sensitive data before every commit, including API endpoints and keys, and internal links
  • I checked that all possible internal and platform/library exceptions are gracefully handled and will not crash the host app
  • I checked for open & known issues (especially crashes) for any newly added platform APIs or libraries
  • I tested non-trivial changes on a real device
  • I added ticket/changes in changelog
  • I ran ./gradlew check without errors

Copy link

sonarcloud bot commented Jun 7, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
0.0% Duplication on New Code

See analysis details on SonarCloud

@rakutentech-danger-bot
Copy link
Collaborator

2 Warnings
⚠️ Tests were not updated.
⚠️ PR title "improve: update debugging logs" should append ticket number(s).

JaCoCo Code Coverage 97.91% ✅

Class Covered Meta Status
com/rakuten/tech/mobile/inappmessaging/runtime/manager/MessageReadinessManager 97% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/manager/SessionManager 50% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/workers/DisplayMessageWorker 88% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/workers/MessageMixerWorker 95% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/workers/ConfigWorker 92% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/workers/MessageEventReconciliationWorker 50% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/repositories/CampaignRepository 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/data/repositories/AccountRepository 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/InAppMessaging 100% 0%
com/rakuten/tech/mobile/inappmessaging/runtime/InApp 96% 0%

Generated by 🚫 Danger

Copy link
Contributor

@mdusmangani-jp mdusmangani-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maureenorea-clores maureenorea-clores merged commit b1ef220 into rakutentech:master Jun 7, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants