Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: fix integration test failure #377

Conversation

maureenorea-clores
Copy link
Collaborator

Description

should return valid ping response test is failing because it validates whether campaign list is empty.
It does not make sense to check it, since campaign list can or cannot have value as it's controlled remotely.
Returning worker success is enough for this test.

Copy link

sonarcloud bot commented May 9, 2024

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rakutentech-danger-bot
Copy link
Collaborator

1 Warning
⚠️ PR title "test: fix integration test failure" should append ticket number(s).

JaCoCo Code Coverage 97.86% ✅

Class Covered Meta Status

Generated by 🚫 Danger

Copy link
Contributor

@mdusmangani-jp mdusmangani-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@maureenorea-clores maureenorea-clores merged commit 95d1ff9 into rakutentech:master May 9, 2024
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants