Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: remove Gemfile.lock from repo to always use latest gem versions for Danger #370

Merged

Conversation

maureenorea-clores
Copy link
Collaborator

@maureenorea-clores maureenorea-clores commented Dec 13, 2023

Description

Fix for Gemfile.lock CI modifications causing build failure during release flow.
As Gemfile only contains Danger, it is fine to allow it to always use the latest gem versions.

Links

N/A

Copy link

sonarcloud bot commented Dec 13, 2023

Quality Gate Passed Quality Gate passed

Kudos, no new issues were introduced!

0 New issues
0 Security Hotspots
No data about Coverage
No data about Duplication

See analysis details on SonarCloud

@rakutentech-danger-bot
Copy link
Collaborator

1 Warning
⚠️ PR title "chore: remove Gemfile.lock from repo to always use latest gem versions for Danger" should append ticket number(s).

JaCoCo Code Coverage 97.6% ✅

Class Covered Meta Status

Generated by 🚫 Danger

Copy link
Contributor

@mdusmangani-jp mdusmangani-jp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@puneetksh puneetksh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@maureenorea-clores maureenorea-clores merged commit 6eeda06 into rakutentech:master Dec 15, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants