build: suppress new sonarqube issues #369

maureenorea-clores · 2023-12-11T02:00:53Z

Description

Suppressed newly introduced Sonarqube issues regarding the use of singletons, as it is causing build failure
Will re-visit these suppressions in the succeeding versions.

Links

N/A

Checklist

I have read the contributing guidelines.
I wrote/updated tests for new/changed code
I removed all sensitive data before every commit, including API endpoints and keys, and internal links
I checked that all possible internal and platform/library exceptions are gracefully handled and will not crash the host app
I checked for open & known issues (especially crashes) for any newly added platform APIs or libraries
I tested non-trivial changes on a real device
I added ticket/changes in changelog
I ran ./gradlew check without errors

rakutentech-danger-bot · 2023-12-11T02:11:40Z

	7 Warnings
⚠️	Tests were not updated.
⚠️	Verb "suppres" in the PR title must be in imperative tense.
⚠️	PR title "build: suppress new sonarqube issues" should append ticket number(s).
⚠️	No coverage data found for com/rakuten/tech/mobile/inappmessaging/runtime/data/repositories/HostAppInfoRepository
⚠️	No coverage data found for com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/schedulers/EventMessageReconciliationScheduler
⚠️	No coverage data found for com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/schedulers/ConfigScheduler
⚠️	No coverage data found for com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/schedulers/MessageMixerPingScheduler

JaCoCo Code Coverage 97.6% ✅

Class	Covered	Meta	Status
`com/rakuten/tech/mobile/inappmessaging/runtime/view/InAppMessagingTooltipView`	74%	0%	✅
`com/rakuten/tech/mobile/inappmessaging/runtime/data/repositories/HostAppInfoRepository`	No coverage data found : -%	No coverage data found : -%	🃏
`com/rakuten/tech/mobile/inappmessaging/runtime/data/repositories/CampaignRepository`	100%	0%	✅
`com/rakuten/tech/mobile/inappmessaging/runtime/data/repositories/AccountRepository`	100%	0%	✅
`com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/schedulers/EventMessageReconciliationScheduler`	No coverage data found : -%	No coverage data found : -%	🃏
`com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/schedulers/ConfigScheduler`	No coverage data found : -%	No coverage data found : -%	🃏
`com/rakuten/tech/mobile/inappmessaging/runtime/workmanager/schedulers/MessageMixerPingScheduler`	No coverage data found : -%	No coverage data found : -%	🃏

Generated by 🚫 Danger

puneetksh

As we have release scheduled for tomorrow, so considering that we may choose to suppress this warning for now and later on we may investigate about removing this annotation i.e. @SuppressWarnings("kotlin:S6515") from the code.

puneetksh · 2023-12-11T07:47:05Z

...kuten/tech/mobile/inappmessaging/runtime/workmanager/schedulers/MessageMixerPingScheduler.kt

@@ -27,6 +27,7 @@ internal interface MessageMixerPingScheduler {
     */
    fun pingMessageMixerService(initialDelay: Long, workManager: WorkManager? = null)

+    @SuppressWarnings("kotlin:S6515")
