「Devise で認証機能を追加」を更新して、"Logout" リンクを Rails 7 Turbo 向けに修正する #801
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This was
linked to
issues
Mar 12, 2024
maimux2x
reviewed
Mar 21, 2024
_pages/devise.md
Outdated
| <p id="notice"><%= notice %></p> | ||
| {% endhighlight %} | ||
|
|
||
| を削除します。 | ||
| というような行を削除します。 |
There was a problem hiding this comment.
細かいのですが、
というような
ではなく、「の行を削除します。」
の方がシンプルかと思いました。
There was a problem hiding this comment.
ありがとうございます。そうですね。そのように変更しました。
maimux2x
reviewed
Mar 21, 2024
_pages/devise.md
Outdated
|
|
||
| ## *5.*ユーザーを作成 | ||
| ## *5.* ユーザーを作成 |
There was a problem hiding this comment.
https://guides.railsgirls.com/devise
英語版の方だと「Create your first user」となっているため「first」の部分を追加した方が良さそうです。
There was a problem hiding this comment.
ここは、入れようかどうしようか迷いました。「最初の」を入れても、あまり意味はないかなぁと思って、そのままにしておいたのですが、とりあえず、ここと本文の方も更新しました。
|
@eitoball |
eitoball
force-pushed
the
update-device-guide
branch
from
9fab2e3 to
cdeddf7
Compare
|
@eitoball |
maimux2x
approved these changes
Mar 24, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.