Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

「あなたのアプリをインターネットに公開しよう」のいくつかのページを更新する #799

Merged
merged 1 commit into from
Mar 21, 2024

Conversation

eitoball
Copy link
Member

@eitoball eitoball commented Mar 9, 2024

  • layout に main_guide に変更
  • {% coach %}{% endcoach %} の使用に変更
  • 本家の更新を反映
    • 「Heroku に Rails アプリを deploy しよう」

@urimaro
Copy link
Collaborator

urimaro commented Mar 19, 2024

@eitoball
PR、ありがとうございます!
修正部分を確認しました
_pages/heroku.md は、https://guides.railsgirls.com/heroku から反映し忘れた部分も追記していただいたと理解しましたが、あっていますか?

@eitoball
Copy link
Member Author

_pages/heroku.md は、https://guides.railsgirls.com/heroku から反映し忘れた部分も追記していただいたと理解しましたが、あっていますか?

あっています。description を更新しました。

Copy link
Collaborator

@urimaro urimaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 です!

@urimaro urimaro merged commit 0e14ee3 into master Mar 21, 2024
2 checks passed
@urimaro urimaro deleted the update-put-your-app-online branch March 21, 2024 01:58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants