Your guide to the Rails Girls Guide!を翻訳した #775
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
maimux2x
force-pushed
the
translate_your_guide_to_the_rails_girls_guide
branch
from
6fc7778 to
c2f1e85
Compare
|
@urimaro |
urimaro
requested changes
Jan 21, 2024
There was a problem hiding this comment.
@maimux2x
確認に時間がかかってしまってすみません 🙇
1つ1つ丁寧に対応していただいて、ありがとうございます
更新された部分のみ確認しました
今までのコメントでわからないこと、気になることがあれば、後からでも構わないので遠慮なく質問してください 🙏
以下のコメント、素晴らしいと思いました
<!-- Rails Girlsガイドでは多言語対応について解説されていないため、英語表記の例のままにしています -->
まさに t-wada さんの「コードコメントには Why notを書こう」ですね！
https://x.com/t_wada/status/904916106153828352?s=20
改行してしまっている箇所を見つけたので、コメントしました
確認をお願いします 🙏
修正したら merge してしまって 👌 です！ 
|
@urimaro |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
やったこと
https://railsgirls.jp/guide-to-the-guide#1_create_the_application を翻訳しました。
close #773