Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Write a little game in Rubyを翻訳した #742

Merged
merged 3 commits into from
Nov 5, 2023
Merged

Write a little game in Rubyを翻訳した #742

merged 3 commits into from
Nov 5, 2023

Conversation

maimux2x
Copy link
Collaborator

@maimux2x maimux2x commented Oct 16, 2023 •
edited
Loading

issue

#676

概要

Write a little game in Rubyを翻訳した

FireShot Capture 046 - Rails Girls - Japanese - localhost

@maimux2x maimux2x marked this pull request as ready for review October 17, 2023 13:07
@maimux2x
Copy link
Collaborator Author

gemのバージョンが古そうなため確認する

@maimux2x
Copy link
Collaborator Author

ガイド上部に説明が古い旨の注意書きを追記しました。

urimaro
urimaro requested changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@urimaro urimaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

コメントしました
確認をお願いします:pray:

_pages/ruby-game.md Outdated Show resolved Hide resolved
_pages/ruby-game.md Outdated Show resolved Hide resolved
_pages/ruby-game.md Outdated Show resolved Hide resolved
_pages/ruby-game.md Outdated Show resolved Hide resolved
_pages/ruby-game.md Outdated Show resolved Hide resolved
_pages/ruby-game.md Show resolved Hide resolved
_pages/ruby-game.md Outdated Show resolved Hide resolved
_pages/ruby-game.md Outdated Show resolved Hide resolved
@urimaro urimaro linked an issue Nov 3, 2023 that may be closed by this pull request
「Write a little game in Ruby!」を翻訳します #676
Closed
urimaro
urimaro approved these changes Nov 5, 2023
View reviewed changes
Copy link
Collaborator

@urimaro urimaro left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM:+1:です！

@urimaro urimaro merged commit 4727f26 into railsgirls-jp:master Nov 5, 2023
2 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@urimaro urimaro urimaro approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

「Write a little game in Ruby!」を翻訳します
2 participants
@maimux2x @urimaro