-
Notifications
You must be signed in to change notification settings - Fork 109
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add Korean Translation for Doctrine #337
base: main
Are you sure you want to change the base?
Conversation
@hahwul I almost did the same thing again 😅. |
@leegeng Hello, Stark! Since this is the first step, I think there's a lot that needs to be improved. Regarding "Doctrine," I agree with you that 원칙 conveys the meaning much better than 교리. Is it okay if I incorporate your feedback into this PR? |
물론이죠, 나중에 이 PR이 머지되면 별도 PR로 의견 드리거나 해볼게요! |
a5028ae
to
8924d78
Compare
@hahwul Matz is Mr. Matsumoto's official nickname, so I think it's okay to spell it Matz rather than 마츠😀. |
@kimdj2 Thanks for pointing that out! I think you're right, "Matz" does sound better. I've gone ahead and made the change. Appreciate your help! |
Add korean doctrine Add korean doctrine Update link for korean doctrine Add korean doctrine Update Korean doctrine content and wording Change 마츠 to Matz
12c3172
to
8e8a798
Compare
Hello!
I have added a Korean translation of the Rails doctrine.
Although this is a small contribution, I hope it will help the community :)