Fix asset url processor regex for where subdirectory starts with 'data' #543
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Our precompilation using sprockets-rails was skipping over processing asset urls that refer to assets inside
app/assets/images/data
.This caused it to not resolve assets referenced in with for example
url('data/foo.png')
function calls and replace them with the digested paths.This was caused by the regular expression in
Sprockets::Rails::AssetUrlProcessor::REGEX
, which wrongfully considered assets indata/
directories to bedata:
protocol assets.This PR fixes the regex to not skip over url() function calls referring to assets in
data/
directories and only skip when thedata
orhttp(s)
protocol in the url is followed by a colon.