-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Makes docs generation work on my computer (basically) #19
Open
localhostdotdev
wants to merge
18
commits into
rails:master
Choose a base branch
from
localhostdotdev:all
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Prevents polluting home directory on non-CI/prod servers
Only fish but quite obvious what is going on for other shells users
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
--verbose
,--target
and--tags
flags (--help
is provided for free byoptparse
)rake test
passrake test:all
pass because doc_generator_test.rb is in "Pending." state :)So this is mostly to give a higher level view of all the changes and it quite nicely lets me do:
And then
python3 -m http.server
lets me see the generated docs.The main thing is I'm waiting for some high-level approval on this PR before writing tests for the three new flags. Maybe trying to revive the old tests too.
(Obviously I just want to fix the links thing on the generated docs and it's related to
rdoc
but might be much more complicated to have something merged inrdoc
than here)(And this PR could use a good rebase too)