Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove information in README about issues with TDS version at login #572

Merged
merged 1 commit into from
Dec 21, 2024

Conversation

andyundso
Copy link
Member

Closes #447

I quickly tested setting the TDS version manually on client initialization and it seems to work as expected. tds_version is implemented in C and asks the dbproc struct about the used version, so this information should be reliable.

irb(main):001> require "tiny_tds"
=> true
irb(main):002* client = TinyTds::Client.new({
irb(main):003*     username: "tinytds",
irb(main):004*     password: "",
irb(main):005*     host: "127.0.0.1",
irb(main):006*     tds_version: "7.3"
irb(main):007> })
=> 
#<TinyTds::Client:0x0000767d1cb58f00
...
irb(main):008> client.tds_version
=> 11
irb(main):009* client = TinyTds::Client.new({
irb(main):010*     username: "tinytds",
irb(main):011*     password: "",
irb(main):012*     host: "127.0.0.1",
irb(main):013*     tds_version: "7.4"
irb(main):014> })
=> 
#<TinyTds::Client:0x0000767d1cb50670
...
irb(main):015> client.tds_version
=> 12

@andyundso andyundso changed the title Remove information in README about issues with TDS version in login Remove information in README about issues with TDS version at login Dec 20, 2024
@andyundso andyundso merged commit 34ca4c7 into rails-sqlserver:master Dec 21, 2024
63 checks passed
@andyundso andyundso deleted the tds-version-cleanup branch December 22, 2024 16:49
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Outdated TDS version information in README?
1 participant