Allow custom layouts via DataFrames in pyvisgen.layouts.get_array_layout
#46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Member
aknierim
commented
Nov 28, 2024
aknierim
commented
- Array layout names can still be passed as before
- The method now also accepts layouts stored in DataFrames which should make it easier to use custom layouts
- Array layout names can still be passed as before - The method now also accepts layouts stored in DataFrames which should make it easier to use custom layouts
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #46 +/- ##
==========================================
+ Coverage 86.28% 87.27% +0.98%
==========================================
Files 13 13
Lines 853 880 +27
==========================================
+ Hits 736 768 +32
+ Misses 117 112 -5 ☔ View full report in Codecov by Sentry. |
tgross03
approved these changes
Jan 7, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.