first step towards image refactoring #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Image.image_id and Image.image_size are both classmethods that conflict with attribute names; the classmethods generate random IDs but the attributes are just values. Move them out to functions.
- Arch Linux
Current coverage is
|
|
Hey @gabecase - we're pretty light on code reviewers right now, do you think you could have a look? |
|
@glyph sure I can look at this some tonight and tomorrow morning, will put some comments here on anything I find |
|
+1 lgtm. Sorry it took so long. |
|
@gabecase: feel free to merge the PR if you don't have any comments. |
|
Ok awesome 2 sets of eyes even better :) checking this out now |
| "Fedora 22 (PVHVM)": {"minRam": 512, "minDisk": 20, | ||
| "OS-EXT-IMG-SIZE:size": Image.image_size(), | ||
| "OS-EXT-IMG-SIZE:size": random_image_size(), |
There was a problem hiding this comment.
👍 I like the re-useable random_image methods for the test data
|
LGTM! |
ghost
pushed a commit
that referenced
this pull request
Dec 4, 2015
first step towards image refactoring
ghost
merged commit 
This pull request was closed.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Begin to address #492 - this is just an initial example of how to use a plain-vanilla Image class rather than a subclass; there's lots more refactoring work to do, but this is a proof of concept.