-
Notifications
You must be signed in to change notification settings - Fork 160
Fix Doom upgrade command #968
base: master
Are you sure you want to change the base?
Conversation
Please also detect |
I don't check for an line 82
|
LET SOME DOOM reads kinda funny, anyways, good to know, thank you :) |
src/steps/emacs.rs
Outdated
if let Some(doom) = &self.doom { | ||
return Emacs::update_doom(doom, ctx); | ||
Emacs::update_doom(doom, ctx) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What's wrong with having return
?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
not sure why i did this.
Take a look now.
Hi @reinaldoossuna - can you please rebase this PR so that we can review and merge it? Also it seems there are still outstanding comments here that need to be addressed |
fix #960