Skip to content
This repository has been archived by the owner on Oct 12, 2022. It is now read-only.

Fix Doom upgrade command #968

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

reinaldoossuna
Copy link

fix #960

@xeruf
Copy link
Contributor

xeruf commented Jul 7, 2022

Please also detect early-init.el next to init.el, otherwise it ignores doom - or did you already fix that?

@reinaldoossuna
Copy link
Author

I don't check for an init.el or early-init.el if the system has doom emacs.

line 82

if let Some(doom) = &self.doom {
    Emacs::update_doom(doom, ctx)
} else {
    let init_file = require_option(self.directory.as_ref(), String::from("Emacs directory does not exist"))?
	....

@xeruf
Copy link
Contributor

xeruf commented Jul 9, 2022

LET SOME DOOM
SELF DOOM

reads kinda funny, anyways, good to know, thank you :)

if let Some(doom) = &self.doom {
return Emacs::update_doom(doom, ctx);
Emacs::update_doom(doom, ctx)
Copy link
Owner

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What's wrong with having return?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

not sure why i did this.

Take a look now.

@vmalloc
Copy link
Collaborator

vmalloc commented Oct 12, 2022

Hi @reinaldoossuna - can you please rebase this PR so that we can review and merge it? Also it seems there are still outstanding comments here that need to be addressed

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Doom Emacs step fails with 'Error: unknown option -y'
4 participants